Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for libignition-launch3 #14412

Merged
merged 4 commits into from
Mar 27, 2021
Merged

Conversation

traversaro
Copy link
Contributor

Related to #13551 . This adds the Ignition Launch library.

Support for macOS and Windows is currently blocked by the following issues in dependent libraries:

So for the time being only Linux is enabled, support for the other platforms will be added as soon as the dependencies are ready.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libignition-launch3) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@wolfv and @Tobias-Fischer already agreed to be maintainers of the ignition libraries in #13551 and related PRs.

@wolfv
Copy link
Member

wolfv commented Mar 27, 2021

Looks great! Happy to merge whenever you say it's ready :)

@traversaro
Copy link
Contributor Author

It is ready!

@wolfv
Copy link
Member

wolfv commented Mar 27, 2021

I had one comment about adding -j${CPU_COUNT} but somehow it doesn't go through on mobile

@wolfv wolfv merged commit 248ce31 into conda-forge:master Mar 27, 2021
@traversaro
Copy link
Contributor Author

I had one comment about adding -j${CPU_COUNT} but somehow it doesn't go through on mobile

You are right, I forgot to add it to the boilerplate that I propagate across repos. I will add it in the feedstock.

@wolfv
Copy link
Member

wolfv commented Mar 27, 2021

Yeah it's not a big deal but when building locally it's a nice speed up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants