Add recipe for libignition-sensors4 #14313

traversaro · 2021-03-20T11:56:21Z

Related to #13551 . This adds a new missing library out of the ignition robotics libraries (see https://ignitionrobotics.org/).

The build on macOS is failing due to the need to 10.13 SDK, as done in #13677 we can merge the recipe and then re-render in the newly created feedstock.

I tried to put the recipe in the libignition-sensors directory even if it creates a libignition-sensors4 package as given that we use a single feedstock to generate all the (different) packages named libignition-sensors<n> we would like it to be called libignition-sensors-feedstock instead of libignition-sensors4-feedstock (as in the future it will host also libignition-sensors5, libignition-sensors5, ...) but to be honest I am not sure it will work. However, this is just a nice to have, nothing really important. Actually we modified the feedstock to specify explicitly its name, see #14313 (comment) .

Checklist

Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
License file is packaged (see here for an example).
Source is from official source.
Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
If static libraries are linked in, the license of the static library is packaged.
Build number is 0.
A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
When in trouble, please check our knowledge base documentation before pinging a team.

conda-forge-linter · 2021-03-20T11:56:25Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/example/libignition-sensors) and found some lint.

Here's what I've got...

For recipes/example/libignition-sensors:

Please move the recipe out of the example dir and into its own dir.
Please do not delete the example recipe found in recipes/example/meta.yaml.

…nition-sensors/meta.yaml

conda-forge-linter · 2021-03-20T11:56:57Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libignition-sensors) and found it was in an excellent condition.

traversaro · 2021-03-20T12:01:21Z

@wolfv @Tobias-Fischer @j-rivero @JShep1 I listed yourself as additional maintainers, please confirm if this is ok for you, or if you prefer not to be a mantainer of this package.

wolfv · 2021-03-20T12:32:34Z

I'm fine with that!

traversaro · 2021-03-20T14:41:47Z

macOS fails with:

In file included from /Users/runner/miniforge3/conda-bld/libignition-sensors4_1616242492432/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/sdformat-10.3/sdf/../sdf/Element.hh:28:
/Users/runner/miniforge3/conda-bld/libignition-sensors4_1616242492432/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/sdformat-10.3/sdf/../sdf/Param.hh:350:37: error: 'get<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, bool, char, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, int, unsigned long long, unsigned int, double, float, sdf::v10::Time, ignition::math::v6::Angle, ignition::math::v6::Color, ignition::math::v6::Vector2<int>, ignition::math::v6::Vector2<double>, ignition::math::v6::Vector3<double>, ignition::math::v6::Quaternion<double>, ignition::math::v6::Pose3<double>>' is unavailable: introduced in macOS 10.13
        std::string strValue = std::get<std::string>(this->dataPtr->value);
                                    ^
/Users/runner/miniforge3/conda-bld/libignition-sensors4_1616242492432/_build_env/bin/../include/c++/v1/variant:1435:16: note: 'get<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, bool, char, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, int, unsigned long long, unsigned int, double, float, sdf::v10::Time, ignition::math::v6::Angle, ignition::math::v6::Color, ignition::math::v6::Vector2<int>, ignition::math::v6::Vector2<double>, ignition::math::v6::Vector3<double>, ignition::math::v6::Quaternion<double>, ignition::math::v6::Pose3<double>>' has been explicitly marked unavailable here
constexpr _Tp& get(variant<_Types...>& __v) {

We probably need to target 10.13 due to the use of recent C++ features.

traversaro · 2021-03-20T15:50:22Z

@conda-forge/help-c-cpp The PR is now ready for review. See the fist comment for an overview, and for the explanation of why the macOS build is failing and it make sense to merge the PR regardless.

traversaro · 2021-03-20T15:50:49Z

@wolfv @Tobias-Fischer @j-rivero @JShep1 I listed yourself as additional maintainers, please confirm if this is ok for you, or if you prefer not to be a mantainer of this package.

For the time being I removed your names, once the PR is merged we can add them back if you want, thanks!

Tobias-Fischer · 2021-03-20T19:22:15Z

I'm happy, too. One remark, last time we merged an ignition feedstock we were wondering if there's a way to avoid having the version number in the feedstock name. Should we try here?

recipes/libignition-sensors/meta.yaml

j-rivero · 2021-03-20T20:09:51Z

For the time being I removed your names, once the PR is merged we can add them back if you want, thanks!

fine for me too. Thanks Silvio

Co-authored-by: Uwe L. Korn <[email protected]>

traversaro · 2021-03-20T22:33:48Z

I'm happy, too. One remark, last time we merged an ignition feedstock we were wondering if there's a way to avoid having the version number in the feedstock name. Should we try here?

@xhochy provided the solution, it is just sufficient to specify the extra.feedstock_name parameter (see #14313 (comment)).

…bignition-sensors4/meta.yaml

conda-forge-linter · 2021-03-20T22:36:00Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libignition-sensors4) and found it was in an excellent condition.

…sors4/bld.bat

…nsors4/build.sh

…libignition-sensors4/conda_build_config.yml

traversaro · 2021-03-20T22:37:02Z

Thanks @Tobias-Fischer @j-rivero , I added you as maintainers.

wolfv · 2021-03-21T07:12:40Z

I think the tests on windows should use if not exists ... exit 1

Happy to merge right after!

traversaro · 2021-03-21T10:09:25Z

I think the tests on windows should use if not exists ... exit 1

Happy to merge right after!

Old habits die hard. : ) Done! I also tried to make the recipe quite parametric, so for future ignition libraries it should be sufficient to just copy the meta.yaml and change dependencies and initial metadata.

wolfv · 2021-03-21T10:26:42Z

recipes/libignition-sensors4/meta.yaml

+    - test -f ${PREFIX}/lib/libignition-{{ component_name }}{{ major_version }}.dylib  # [osx]
+    - test -f ${PREFIX}/lib/cmake/ignition-{{ component_name }}{{ major_version }}/ignition-{{ component_name }}{{ major_version }}-config.cmake  # [not win]
+    - if not exist %PREFIX%\\Library\\include\\ignition\\{{ component_name }}{{ major_version }}\\ignition\\{{ component_name }}.hh exit 1  # [win]
+    - if not exist $PREFIX$\\Library\\lib\\ignition-{{ component_name }}{{ major_version }}.lib (exit 0) exit 1  # [win]


I think here is still a typo?
Instead of (exit 0) exit 1, it should just be (exit 1), right?

Yes, fixed now, sorry for the noise.

traversaro · 2021-03-21T11:26:41Z

After the changes the Windows existence checks are failing, not sure why.

wolfv · 2021-03-21T11:39:36Z

yeah the build log is really inconclusive :/ . Let me restart the windows build

traversaro · 2021-03-21T12:13:26Z

yeah the build log is really inconclusive :/ . Let me restart the windows build

There is the same failure in #14323 that was copy pasted from this, so i guess there is some typo in the check, looking at it again.

traversaro · 2021-03-21T12:14:39Z

yeah the build log is really inconclusive :/ . Let me restart the windows build

There is the same failure in #14323 that was copy pasted from this, so i guess there is some typo in the check, looking at it again.

Found it, it was $PREFIX$ instead of the correct %PREFIX%.

Create meta.yaml

3c55f7c

Rename recipes/example/libignition-sensors/meta.yaml to recipes/libig…

97bdb0d

…nition-sensors/meta.yaml

traversaro added 2 commits March 20, 2021 12:58

Create bld.bat

717d12f

Create build.sh

e29ac09

traversaro added 3 commits March 20, 2021 13:09

Update meta.yaml

a630aa0

Update meta.yaml

5a7b206

Update meta.yaml

fbbd9c8

traversaro added 2 commits March 20, 2021 15:44

Create conda_build_config.yml

7079979

Update conda_build_config.yml

154f2d7

traversaro mentioned this pull request Mar 20, 2021

Add recipes for missing ignition libraries #13551

Closed

6 tasks

traversaro added 3 commits March 20, 2021 15:50

Update meta.yaml

1ac191a

Update build.sh

7276a64

Update meta.yaml

dd24662

traversaro changed the title ~~[WIP] Add recipe for libignition-sensors4~~ Add recipe for libignition-sensors4 Mar 20, 2021

xhochy reviewed Mar 20, 2021

View reviewed changes

recipes/libignition-sensors/meta.yaml Outdated Show resolved Hide resolved

Update recipes/libignition-sensors/meta.yaml

1885619

Co-authored-by: Uwe L. Korn <[email protected]>

Update and rename recipes/libignition-sensors/meta.yaml to recipes/li…

cc0f8b1

…bignition-sensors4/meta.yaml

traversaro added 2 commits March 20, 2021 23:36

Rename recipes/libignition-sensors/bld.bat to recipes/libignition-sen…

a5d11b8

…sors4/bld.bat

Rename recipes/libignition-sensors/build.sh to recipes/libignition-se…

8737291

…nsors4/build.sh

Rename recipes/libignition-sensors/conda_build_config.yml to recipes/…

fa38e84

…libignition-sensors4/conda_build_config.yml

Update meta.yaml

bd904dd

traversaro added 2 commits March 21, 2021 11:16

Update bld.bat

5b7873e

Update build.sh

9d3055a

wolfv reviewed Mar 21, 2021

View reviewed changes

Update meta.yaml

8d0c10b

Update meta.yaml

69a67f9

wolfv merged commit 8cf4b26 into conda-forge:master Mar 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recipe for libignition-sensors4 #14313

Add recipe for libignition-sensors4 #14313

traversaro commented Mar 20, 2021 •

edited

Loading

conda-forge-linter commented Mar 20, 2021

conda-forge-linter commented Mar 20, 2021

traversaro commented Mar 20, 2021

wolfv commented Mar 20, 2021

traversaro commented Mar 20, 2021

traversaro commented Mar 20, 2021

traversaro commented Mar 20, 2021

Tobias-Fischer commented Mar 20, 2021

j-rivero commented Mar 20, 2021

traversaro commented Mar 20, 2021

conda-forge-linter commented Mar 20, 2021

traversaro commented Mar 20, 2021

wolfv commented Mar 21, 2021

traversaro commented Mar 21, 2021

wolfv Mar 21, 2021

traversaro Mar 21, 2021

traversaro commented Mar 21, 2021

wolfv commented Mar 21, 2021

traversaro commented Mar 21, 2021

traversaro commented Mar 21, 2021

Add recipe for libignition-sensors4 #14313

Add recipe for libignition-sensors4 #14313

Conversation

traversaro commented Mar 20, 2021 • edited Loading

conda-forge-linter commented Mar 20, 2021

conda-forge-linter commented Mar 20, 2021

traversaro commented Mar 20, 2021

wolfv commented Mar 20, 2021

traversaro commented Mar 20, 2021

traversaro commented Mar 20, 2021

traversaro commented Mar 20, 2021

Tobias-Fischer commented Mar 20, 2021

j-rivero commented Mar 20, 2021

traversaro commented Mar 20, 2021

conda-forge-linter commented Mar 20, 2021

traversaro commented Mar 20, 2021

wolfv commented Mar 21, 2021

traversaro commented Mar 21, 2021

wolfv Mar 21, 2021

Choose a reason for hiding this comment

traversaro Mar 21, 2021

Choose a reason for hiding this comment

traversaro commented Mar 21, 2021

wolfv commented Mar 21, 2021

traversaro commented Mar 21, 2021

traversaro commented Mar 21, 2021

traversaro commented Mar 20, 2021 •

edited

Loading