Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v0.1.3 #2

Closed
wants to merge 9 commits into from
Closed

Bump to v0.1.3 #2

wants to merge 9 commits into from

Conversation

basnijholt
Copy link
Contributor

Fix the merge of #1

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

We have a working fix for conda-smithy pending. Should be out in the next couple of days. So I wouldn't worry too much about fixing this right now (unless it is time sensitive). If it is, please let me know and we can work something out.

@jakirkham
Copy link
Member

So re-rendering with conda-smithy 2.2.2 should work.

@basnijholt basnijholt changed the title MNT: Re-rendered with conda-smithy 2.1.1 MNT: Re-rendered with conda-smithy 2.2.2 Mar 24, 2017
@basnijholt
Copy link
Contributor Author

Thanks I just did.

@basnijholt basnijholt changed the title MNT: Re-rendered with conda-smithy 2.2.2 Bump to v0.1.3 Mar 24, 2017
@basnijholt
Copy link
Contributor Author

@jakirkham @AdriaanRol @alexcjohnson do you have any idea why these builds are failing?

Might be related to microsoft/Qcodes#540

recipe/meta.yaml Outdated
- PyQt5 ==5.7.1
- sip ==4.19
- QtPy ==1.2.0
- h5py ==2.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is everything so tightly pinned like this? Seems like this will cause issues.

Also the indentation appears to be incorrect w.r.t run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just following whatever happened in https://github.com/QCoDeS/Qcodes/blob/v0.1.3/requirements.txt

I fixed the indentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are normally used to create identical dev environments not specify versions for user installs. Please use this list, which is the same one pip would use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also may want these extras. Though that is up to you as a user can always install them if they wish.

Copy link
Contributor Author

@basnijholt basnijholt Mar 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments!

I have updated the versions and packages, but the error is still the same.

@jakirkham
Copy link
Member

Sort of a dumb question, but is the license file in the source?

@basnijholt
Copy link
Contributor Author

They changed the extension of the license, I've corrected it, thanks for spotting.

This conda-forge/pyvisa-feedstock#6 probably solves the dependency issue.

@jakirkham
Copy link
Member

If you aren't wanting to dive into building everything for Python 3.6 right now, you can add a skip and re-render to just not do Python 3.6. Then when you have more time you can dig into it. Just a thought.

@basnijholt
Copy link
Contributor Author

basnijholt commented Mar 24, 2017

Good point!

Pinning py35 didn't help though.

I am going to leave this here as it is now. I welcome the qcodes team to contribute :)

@ocefpaf ocefpaf closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants