Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] test pyzmq 26 prerelease #103

Closed
wants to merge 10 commits into from
Closed

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 19, 2024

pyzmq 26 is now built with scikit-build-core instead of setuptools.

Checking to see if I'm breaking anything on conda-forge (especially curious about cross-compiling).

Relevant packaging changes:

  • build system is totally different (requires cmake, ninja, setup.cfg doesn't exist)
  • cython is a build-time dependency
  • license is purely BSD

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk minrk changed the title test pyzmq prerelease [do not merge] test pyzmq 26 prerelease Feb 19, 2024
@minrk minrk force-pushed the pyzmq-26 branch 3 times, most recently from fd78179 to 49a67fe Compare February 19, 2024 13:19
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@minrk
Copy link
Member Author

minrk commented Feb 19, 2024

seems to work! Weird pytest/pypy issue doesn't seem to be related: conda-forge/pycalphad-feedstock#55

don't need prefix

pkg-config / cmake will find it
@minrk minrk force-pushed the pyzmq-26 branch 2 times, most recently from 7f285c7 to 4928247 Compare February 19, 2024 20:39
@minrk minrk marked this pull request as ready for review February 19, 2024 20:59
@minrk minrk marked this pull request as draft February 19, 2024 21:00
@minrk minrk closed this Apr 15, 2024
@minrk minrk deleted the pyzmq-26 branch April 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant