Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the recipe autotickbot-compatible #251

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Jul 29, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged) not needed
  • Reset the build number to 0 (if the version changed) not needed
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

These changes make the recipe compatible with the autotickbot again. I verified locally that migrations work successfully with this.

Closes #243

@ytausch
Copy link
Contributor Author

ytausch commented Jul 29, 2024

@conda-forge-admin please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@pavelzw pavelzw added the automerge Merge the PR when CI passes label Jul 29, 2024
@ytausch
Copy link
Contributor Author

ytausch commented Jul 29, 2024

Oops, I think there might still be something wrong here. Forgot to set the name of the feedstock outputs, converting to draft (hopefully this will stop automerge?) @pavelzw

@ytausch ytausch marked this pull request as draft July 29, 2024 18:57
@pavelzw pavelzw removed the automerge Merge the PR when CI passes label Jul 29, 2024
@ytausch
Copy link
Contributor Author

ytausch commented Jul 29, 2024

@conda-forge-admin please rerender

@ytausch
Copy link
Contributor Author

ytausch commented Jul 29, 2024

I think this should be it. Confirmed again that the bot works, and setting package.name dynamically is apparently supported. @pavelzw

@ytausch ytausch marked this pull request as ready for review July 29, 2024 19:13
@pavelzw pavelzw added the automerge Merge the PR when CI passes label Jul 29, 2024
@github-actions github-actions bot merged commit 511147e into conda-forge:main Jul 30, 2024
83 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging separate projects causes autotick-bot to malfunction, no automatic version updates
2 participants