Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop numpy 1.21 per NEP29 #4730

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Jul 29, 2023

Following @h-vetinari in #4214

It's NEP29 time again, which says

On Jan 31, 2023 drop support for NumPy 1.20 (initially released on Jan 31, 2021)
Previous PRs along these lines: #3420 #2600

NEP29: https://numpy.org/neps/nep-0029-deprecation_policy.html

On Jun 23, 2023 drop support for NumPy 1.21 (initially released on Jun 22, 2021)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@ngam ngam requested a review from a team as a code owner July 29, 2023 22:42
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam ngam changed the title increase numpy pin to 1.22 per nep29 drop numpy 1.21 per NEP29 Jul 29, 2023
@ngam ngam mentioned this pull request Jul 30, 2023
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'm not 100% sure we want to formulate the policy so strongly, but it's been working fine for a while already, so I'm not against it. I'd suggest to soften the formulation a bit to give ourselves a little wiggle room.

recipe/conda_build_config.yaml Outdated Show resolved Hide resolved
Co-authored-by: h-vetinari <[email protected]>
Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ mamba install --yes nep29 && nep29 numpy
| version |    date    |
|:-------:|:----------:|
|  1.25.0 | 2023-06-17 |
|  1.24.0 | 2022-12-18 |
|  1.23.0 | 2022-06-22 |
|  1.22.0 | 2021-12-31 |

@h-vetinari
Copy link
Member

This should be uncontroversial (we've been following NEP29 w.r.t. to numpy with small delays for ~2 years already), so in it goes. Thanks @ngam!

@h-vetinari h-vetinari merged commit 5efe932 into conda-forge:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants