Requirements spec #203
Requirements spec #203
Conversation
|
This is missing a big piece of my PR, which is the ability to have conda figure out which dependencies are available via conda and which it needs to use pip for. That's actually the whole reason I put together my PR. This is just an alternative format to list conda dependencies. |
|
oh, so you want to have a single list of commands and having conda-env figure out which one is in conda and which on is in pypi? am I right? |
|
Yeah, exactly. This is mostly useful because most of the projects I work on the other devs do not use conda, so having to always go through the requirements list and then manually conda install everything myself was a pain. Also, dependencies are the real issue here, because often times something won't be available via conda, but it relies on numpy or pandas, which should be installed via conda. That's why my PR has this function to get all of the pip dependencies. And then the logic here that checks what's available via conda and what is not (and it knows to skip editable packages, because those are only for pip). |
|
Also, pip needs to be called like this in order for editable packages to be checked out within the conda environment instead of just in the current directory. And passing on the command-line arguments for editable packages is tricky too. |
| self.name = name | ||
| self.msg = None | ||
|
|
||
| def can_handle(self): |
There was a problem hiding this comment.
It would be nice to have normal methods after private ones...
so
def __init__ ...
def _valid_file ...
def _valid_name ....
def can_handle ...
|
|
|
||
| def _valid_name(self): | ||
| if self.name is None: | ||
| self.msg = "Environment with requierements.txt file needs a name" |
There was a problem hiding this comment.
There is a typo here:
requierements.txt should be requirements.txt
A replacement for #172
@dan-blanchard, what do you think?