build: Change Vite server port to 5173 #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx! |
alee
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
good work sleuthing that one out, it seemed like the vite server was binding just fine to 5000 from the logs but looking at https://stackoverflow.com/questions/69818376/localhost5000-unavailable-in-macos-v12-monterey and https://stackoverflow.com/questions/72369320/why-always-something-is-running-at-port-5000-on-my-mac + other posts it's definitely a thing!
|
only nitpick I'd add to this for the future is to consider making this an environment variable in dev.yml and thread it through to the server and vite containers (i.e., read it from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port 5000 seems to be reserved by some MacOS process (AirTunes is referenced in the response headers). Changing the port should allow the Vite server to successfully be accessed by the django server on MacOS.
Resolves comses/infra#192