-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): upgrade to debian bookworm node-lts #684
Conversation
that seems like yarn itself can't find git, somehow.. |
right, maybe there's a git+ssh dependency somewhere in there? I'm not sure why |
I just had that same problem upgrading stuff on pom but it got resolved by hard refreshing (deleting/reinstalling) yarn.lock |
That seems like it did the trick (it just bumped eslint). I can push the new lockfile if it won't mess with your branch |
Hmm, I rebuilt the lockfile and the container without git and yarn still complains about git. Or are you talking about just fixing the |
I meant the git binary issue didn't come up for me, though I'm realizing now I didn't actually make sure the container rebuilt fully |
some package in package.json requires a binary version of git for some reason and was causing `yarn upgrade` to fail. should investigate further... ``` root@24de4b0e2c6e:/code# yarn upgrade yarn upgrade v1.22.19 [1/4] Resolving packages... error Couldn't find the binary git ```
ignore generated .yarn and .yarnrc.yml for now, still evaluating if it's better practice to include it in the repo
modern yarn seems to be causing the github action to run out of memory (exit code 137) and killing the vite container, need to investigate further when time permits |
presumably yarn PnP uses way more memory than the runner has. I also can't manage to get the default PnP install strategy working at all with docker locally. Was that the intent with upgrading to yarn modern? |
Co-authored-by: sgfost <[email protected]>
container dies when it cant find the specific yarn binary * add recommended ignores for yarn without zero-install
+ yarn upgrade
yarn seems to revert itself to v1 if we don't specify and commit the binary looks like corepack https://yarnpkg.com/corepack may be the way to lock the yarn vers. without needing to commit the whole thing |
deps upgrade to django-modelcluster to 6.2.0+ should resolve comses/planning#184 Keep looking for more N+1s and other inefficient queries via DDT
Seems to be failing regardless of any of those upgrades (including pinning django-modelcluster to 6.1). I'm going to try debugging the test but I have no idea how the issue could have suddenly arisen |
Oh whoops.. y2k bug in those tests. Satisfying yet very silly conclusion |
leap year bugs are the best |
some package in package.json requires a binary version of git for some reason and was causing
yarn upgrade
to fail. should investigate further...also attempting an upgrade to yarn modern: https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern