Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade to debian bookworm node-lts #684

Merged
merged 10 commits into from
Jan 5, 2024
Merged

build(deps): upgrade to debian bookworm node-lts #684

merged 10 commits into from
Jan 5, 2024

Conversation

alee
Copy link
Member

@alee alee commented Nov 16, 2023

some package in package.json requires a binary version of git for some reason and was causing yarn upgrade to fail. should investigate further...

root@24de4b0e2c6e:/code# yarn upgrade
yarn upgrade v1.22.19
[1/4] Resolving packages...
error Couldn't find the binary git

also attempting an upgrade to yarn modern: https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern

@sgfost
Copy link
Contributor

sgfost commented Nov 16, 2023

that seems like yarn itself can't find git, somehow..

@alee
Copy link
Member Author

alee commented Nov 17, 2023

right, maybe there's a git+ssh dependency somewhere in there?

I'm not sure why yarn lint is failing here, seems fine on my local system..

@sgfost
Copy link
Contributor

sgfost commented Nov 17, 2023

I just had that same problem upgrading stuff on pom but it got resolved by hard refreshing (deleting/reinstalling) yarn.lock

@sgfost
Copy link
Contributor

sgfost commented Nov 17, 2023

That seems like it did the trick (it just bumped eslint). yarn upgrade also works for me locally

I can push the new lockfile if it won't mess with your branch

@alee
Copy link
Member Author

alee commented Nov 18, 2023

That seems like it did the trick (it just bumped eslint). yarn upgrade also works for me locally

I can push the new lockfile if it won't mess with your branch

Hmm, I rebuilt the lockfile and the container without git and yarn still complains about git. Or are you talking about just fixing the yarn lint issue that's failing this build?

@sgfost
Copy link
Contributor

sgfost commented Nov 18, 2023

I meant the git binary issue didn't come up for me, though I'm realizing now I didn't actually make sure the container rebuilt fully

some package in package.json requires a binary version of git for some
reason and was causing `yarn upgrade` to fail. should investigate
further...

```
root@24de4b0e2c6e:/code# yarn upgrade
yarn upgrade v1.22.19
[1/4] Resolving packages...
error Couldn't find the binary git
```
alee added 2 commits November 20, 2023 18:11
ignore generated .yarn and .yarnrc.yml for now, still evaluating if it's
better practice to include it in the repo
@alee
Copy link
Member Author

alee commented Nov 21, 2023

modern yarn seems to be causing the github action to run out of memory (exit code 137) and killing the vite container, need to investigate further when time permits

@sgfost
Copy link
Contributor

sgfost commented Nov 27, 2023

presumably yarn PnP uses way more memory than the runner has. I also can't manage to get the default PnP install strategy working at all with docker locally. Was that the intent with upgrading to yarn modern?

alee and others added 3 commits November 28, 2023 11:15
container dies when it cant find the specific yarn binary

* add recommended ignores for yarn without zero-install
@sgfost
Copy link
Contributor

sgfost commented Dec 7, 2023

yarn seems to revert itself to v1 if we don't specify and commit the binary

looks like corepack https://yarnpkg.com/corepack may be the way to lock the yarn vers. without needing to commit the whole thing

@alee alee changed the title build(deps): upgrade to debian bullseye node-lts build(deps): upgrade to debian bookworm node-lts Jan 4, 2024
deps upgrade to django-modelcluster to 6.2.0+ should resolve
comses/planning#184

Keep looking for more N+1s and other inefficient queries via DDT
@alee
Copy link
Member Author

alee commented Jan 5, 2024

@sgfost any ideas why these tests are failing now? I didn't see anything in the wagtail 5.2.2 release notes, perhaps a different dependency upgrade? d960a22

@sgfost
Copy link
Contributor

sgfost commented Jan 5, 2024

Seems to be failing regardless of any of those upgrades (including pinning django-modelcluster to 6.1). I'm going to try debugging the test but I have no idea how the issue could have suddenly arisen

@sgfost
Copy link
Contributor

sgfost commented Jan 5, 2024

Oh whoops.. y2k bug in those tests. Satisfying yet very silly conclusion

@alee
Copy link
Member Author

alee commented Jan 5, 2024

Oh whoops.. y2k bug in those tests. Satisfying yet very silly conclusion

leap year bugs are the best

@alee alee merged commit 82c5763 into main Jan 5, 2024
5 checks passed
@alee alee deleted the vite-bookworm branch January 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants