Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional UI changes/fixes for release detail page #659

Merged
merged 13 commits into from
Jul 27, 2023
Merged

Additional UI changes/fixes for release detail page #659

merged 13 commits into from
Jul 27, 2023

Conversation

sgfost
Copy link
Contributor

@sgfost sgfost commented Jul 18, 2023 •
edited
Loading

Changes

  • reduce global border radius
  • slightly lighten metadata sidebar/blocks color
  • show private info on unpublished releases with change perms
  • clean up metadata sidebar formatting
  • add framework and remove 'dependencies' from sidebar
  • replace lang/framework with publish dates in subheader metadata
  • add image gallery for codebases with multiple images uploaded
  • resolves comses/planning#128
  • resolves comses/planning#126
  • resolves comses/planning#132

@sgfost sgfost added the ui/ux label Jul 18, 2023
@sgfost sgfost marked this pull request as draft July 18, 2023 21:31
@sgfost sgfost force-pushed the general-release-ui-tweaks branch 2 times, most recently from 4b56773 to d320f9c Compare July 19, 2023 00:35
@sgfost
Copy link
Contributor Author

sgfost commented Jul 19, 2023

example:
release detail - https://staging.comses.net/codebases/6ade3057-9392-4eda-849d-995407b67acb/releases/8.0.0/
corresponding discussion - https://staging-discourse.comses.net/t/short-title/165

@alee alee changed the title Additonal UI changes/fixes for release detail page Additional UI changes/fixes for release detail page Jul 19, 2023
@alee
Copy link
Member

alee commented Jul 19, 2023 •
edited
Loading

example: release detail - https://staging.comses.net/codebases/6ade3057-9392-4eda-849d-995407b67acb/releases/8.0.0/ corresponding discussion - https://staging-discourse.comses.net/t/short-title/165

Looks good! Should we consider including a few other metadata fields:

Codebase

  • references_text
  • replication_text
  • repository_url

CodebaseRelease

  • doi_url
  • platform_tags / programming_languages
  • license
  • output_data_url (though this reminds me that I don't think we ever finished wiring that field up to the UI... it's intended to be a permanent URL / DOI to a landing page for where the model's simulation outputs have been archived)

Might not need all of them but.. maybe?

@comses/editors please review also

@sgfost
Copy link
Contributor Author

sgfost commented Jul 19, 2023

I was going for a more minimal post and just assume people would follow the link to the model in the library for more details, though I'm not opposed to copying over more info. Can see what others' thoughts are

While we're on it, the repo url should probably get added to the sidebar and output_data_url can be put into the release metadata form

sgfost added 6 commits July 24, 2023 17:33
@sgfost
feat: minor global style changes
ef3f110 
- reduce global border radius
- slightly lighten metadata sidebar/blocks color
@sgfost
feat: re-organize/style release detail page
ad8b9af 
- show private info on unpublished releases with change perms
- clean up metadata sidebar formatting
- add framework and remove 'dependencies' from sidebar
- replace lang/framework with publish dates in subheader metadata

resolves comses/planning#128
@sgfost
feat: use pre-formatted hidden section for discourse posts
98a81e6 
resolves comses/planning#126

fix: use hidden div for exposing discourse post content
@sgfost
feat: add output data/repo url to release detail
e24b1fe 
- include output_data_url in release metadata form
@sgfost
style: fix formatting, remove commented markup
3733c4b
@sgfost
feat: add image gallery for release page
5cba9a6 
done with vue due to lack of flexibility and difficulty to maintain
bootstrap carousel in templates. the first image is displayed similarly
to how it was until the vue component gets mounted, just in the interest
of progressive enhancement

component is not tied to codebase images in any way and can be used for
any set of images

resolves comses/planning#132
@sgfost sgfost force-pushed the general-release-ui-tweaks branch from e25ea4f to 5cba9a6 Compare July 25, 2023 00:37
@sgfost sgfost marked this pull request as ready for review July 25, 2023 00:53
@sgfost
Copy link
Contributor Author

sgfost commented Jul 25, 2023

Still some things to discuss and figure out here but the image gallery was the last feature/addition I wanted to add to this PR

how it looks:

Screenshot from 2023-07-24 17-53-02

@alee alee force-pushed the general-release-ui-tweaks branch from 96d22cb to 88dec70 Compare July 27, 2023 20:20
@alee alee merged commit 198269c into comses:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgfost @alee