-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digest archives #630
Merged
Merged
Add digest archives #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alee
requested changes
Mar 23, 2023
- add DigestArchive model to index digests - add management command update_digest_archive to create DigestArchive objects from static files - remove mailchimp js loading/caching etc with simple listview
also give better error/success messages
- renamed DigestArchive -> ComsesDigest
- use utility classes instead of css in style tag - grouped by year, make list items more readable - removed mailchimp sign up link for now
alee
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Scott! Added a few minor changes.
Sweet, thanks for the style changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds digest archives up to Summer 2022 as static files (pdf)
Reworked
DigestView
to be a simpler list view ofDigestArchive
s which are basically just metadata and a pointer to the static file.DigestArchive
s are automatically created via a new management command, given the name of the file added to the static directory is formatted well-enoughresolves comses/planning#96