fix: correct inconsistent use of camelCase json renderer

- remove renderer class overrides on some API views, instead relying on
  the new default CamelCaseJSONRenderer
- fix permissions for peer review list_review_event_log
- correct multi-word values for sort/filtering which mistakenly got
  camelCased

django/home/views.py

@@ -19,13 +19,11 @@
     parsers,
     status,
     mixins,
-    renderers,
     filters,
 )
 from rest_framework.decorators import action
 from rest_framework.filters import OrderingFilter
 from rest_framework.permissions import IsAuthenticated, AllowAny
-from rest_framework.renderers import JSONRenderer, TemplateHTMLRenderer
 from rest_framework.response import Response
 from rest_framework.views import APIView
 from taggit.models import Tag
@@ -83,7 +81,6 @@ def get_redirect_url(self, *args, **kwargs):
 
 class ToggleFollowUser(APIView):
     permission_classes = (IsAuthenticated,)
-    renderer_classes = (TemplateHTMLRenderer, JSONRenderer)
 
     def post(self, request, *args, **kwargs):
         logger.debug("POST with request data: %s", request.data)
@@ -104,7 +101,6 @@ class TagListView(mixins.ListModelMixin, viewsets.GenericViewSet):
     serializer_class = TagSerializer
     queryset = Tag.objects.all()
     pagination_class = SmallResultSetPagination
-    renderer_classes = (renderers.JSONRenderer,)
     permission_classes = (AllowAny,)
 
     def get_queryset(self):

django/library/views.py

@@ -240,7 +240,6 @@ def has_permission(self, request, view):
 class PeerReviewInvitationViewSet(NoDeleteNoUpdateViewSet):
     queryset = PeerReviewInvitation.objects.with_reviewer_statistics()
     permission_classes = (NestedPeerReviewInvitation,)
-    renderer_classes = (renderers.JSONRenderer,)
     serializer_class = PeerReviewInvitationSerializer
     lookup_url_kwarg = "invitation_slug"
 
@@ -306,7 +305,6 @@ def get_success_url(self):
 
 class PeerReviewFeedbackViewSet(NoDeleteNoUpdateViewSet):
     queryset = PeerReviewerFeedback.objects.all()
-    renderer_classes = (renderers.JSONRenderer,)
     serializer_class = PeerReviewFeedbackEditorSerializer
 
     def get_queryset(self):
@@ -368,12 +366,8 @@ def get_success_url(self):
 @permission_classes([])
 def list_review_event_log(request, slug):
     review = get_object_or_404(PeerReview, slug=slug)
-    if (
-        not MemberProfile.objects.editors()
-        .filter(pk=request.user.member_profile.pk)
-        .exists()
-    ):
-        raise Http404()
+    if not request.user.has_perm("library.change_peerreview"):
+        raise PermissionDenied()
     queryset = review.event_set.order_by("-date_created")[:10]
     serializer = PeerReviewEventLogSerializer(queryset, many=True)
     return Response(serializer.data)
@@ -521,7 +515,6 @@ class CodebaseImageViewSet(mixins.ListModelMixin, viewsets.GenericViewSet):
     lookup_value_regex = r"\d+"
     queryset = CodebaseImage.objects.all()
     serializer_class = CodebaseImageSerializer
-    renderer_classes = (renderers.JSONRenderer,)
     permission_classes = (CodebaseImagePermission,)
 
     def get_queryset(self):
@@ -897,7 +890,7 @@ def download(self, request, **kwargs):
 
         return response
 
-    @action(detail=True, methods=["get"], renderer_classes=(renderers.JSONRenderer,))
+    @action(detail=True, methods=["get"])
     def download_preview(self, request, **kwargs):
         codebase_release = self.get_object()
         fs_api = codebase_release.get_fs_api()
@@ -915,7 +908,6 @@ class BaseCodebaseReleaseFilesViewSet(viewsets.GenericViewSet):
         NestedCodebaseReleaseUnpublishedFilesPermission,
         CodebaseReleaseUnpublishedFilePermissions,
     )
-    renderer_classes = (renderers.JSONRenderer,)
 
     stage = None
 
@@ -991,8 +983,6 @@ def get_list_url(self, api):
 
 
 class CodebaseReleaseFilesOriginalsViewSet(BaseCodebaseReleaseFilesViewSet):
-    renderer_classes = (renderers.JSONRenderer,)
-
     stage = StagingDirectories.originals
 
     def get_list_url(self, api):

frontend/src/apps/codebase_list.ts

@@ -8,8 +8,8 @@ createApp(CodebaseListSidebar).mount("#sidebar");
 createApp(SortBy, {
   sortOptions: [
     { value: "", label: "Relevance" },
-    { value: "-firstPublishedAt", label: "Publish date: newest" },
-    { value: "firstPublishedAt", label: "Publish date: oldest" },
-    { value: "lastModified", label: "Recently Modified" },
+    { value: "-first_published_at", label: "Publish date: newest" },
+    { value: "first_published_at", label: "Publish date: oldest" },
+    { value: "-last_modified", label: "Recently Modified" },
   ],
 }).mount("#sortby");

frontend/src/apps/event_list.ts

@@ -8,11 +8,11 @@ createApp(EventListSidebar).mount("#sidebar");
 createApp(SortBy, {
   sortOptions: [
     { label: "Relevance", value: "" },
-    { label: "Date posted: newest", value: "-dateCreated" },
-    { label: "Date posted: oldest", value: "dateCreated" },
-    { label: "Start date", value: "startDate" },
-    { label: "Submission deadline", value: "submissionDeadline" },
-    { label: "Early reg. deadline", value: "earlyRegistrationDeadline" },
-    { label: "Recently modified", value: "lastModified" },
+    { label: "Date posted: newest", value: "-date_created" },
+    { label: "Date posted: oldest", value: "date_created" },
+    { label: "Start date", value: "start_date" },
+    { label: "Submission deadline", value: "submission_deadline" },
+    { label: "Early reg. deadline", value: "early_registration_deadline" },
+    { label: "Recently modified", value: "-last_modified" },
   ],
 }).mount("#sortby");

frontend/src/apps/job_list.ts

@@ -8,10 +8,9 @@ createApp(JobListSidebar).mount("#sidebar");
 createApp(SortBy, {
   sortOptions: [
     { label: "Relevance", value: "" },
-    { label: "Date posted: newest", value: "-dateCreated" },
-    { label: "Date posted: oldest", value: "dateCreated" },
-    { label: "Deadline: furthest", value: "-applicationDeadline" },
-    { label: "Deadline: nearest", value: "applicationDeadline" },
-    { label: "Recently modified ", value: "lastModified" },
+    { label: "Date posted: newest", value: "-date_created" },
+    { label: "Date posted: oldest", value: "date_created" },
+    { label: "Application Deadline", value: "application_deadline" },
+    { label: "Recently modified ", value: "-last_modified" },
   ],
 }).mount("#sortby");

frontend/src/components/CodebaseListSidebar.vue

@@ -39,7 +39,7 @@ import { useCodebaseAPI } from "@/composables/api";
 
 const peerReviewOptions = [
   { value: "reviewed", label: "Reviewed" },
-  { value: "notReviewed", label: "Not Reviewed" },
+  { value: "not_reviewed", label: "Not Reviewed" },
   { value: "", label: "Any" },
 ];