check that a container_name is used only once across all services declarations #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larations Signed-off-by: Guillaume Lours <[email protected]>
ndeloof
reviewed
Feb 20, 2024
| @@ -29,6 +29,7 @@ import ( | |||
|
|
|||
| // checkConsistency validate a compose model is consistent | |||
| func checkConsistency(project *types.Project) error { | |||
| containerNames := map[string]string{} | |||
There was a problem hiding this comment.
could use utils.Set, which offers Has method
There was a problem hiding this comment.
I can't keep the original service name with a Set only the container_name value
jhrotko
approved these changes
Feb 20, 2024
ndeloof
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #583