Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retryCodes option in HttpMiddlewareOptions #1763

Closed
wants to merge 1 commit into from

Conversation

ajimae
Copy link
Contributor

@ajimae ajimae commented Feb 9, 2022

Summary

  • add retryCodes option to HttpMiddlewareOptions
  • add unit test
  • add documentation
  • add flow types
  • remove deprecated options from .flowconfig

Description

This adds options to allow customers retry requests on a given status (error) codes.

  • Tests
    • Unit
  • Documentation

Related Issue:

#1743

Note:
Direct file changes are:

Others are as a result of flow (lint:format) changes.

- add retryCodes option to HttpMiddlewareOptions
- add unit test
- add documentation
- add flow types
- remove deprecated options from .flowconfig
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

⚠️ No Changeset found

Latest commit: 2046b6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1763 (2046b6c) into master (16dff86) will increase coverage by 0.00%.
The diff coverage is 93.04%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         135      135           
  Lines        4792     4795    +3     
  Branches     1275     1278    +3     
=======================================
+ Hits         4517     4520    +3     
  Misses        271      271           
  Partials        4        4           
Impacted Files Coverage Δ
.../sdk-middleware-auth/src/anonymous-session-flow.js 84.61% <77.77%> (ø)
...sdk-middleware-auth/src/client-credentials-flow.js 85.71% <77.77%> (ø)
packages/sdk-middleware-auth/src/password-flow.js 84.61% <77.77%> (ø)
...ages/sdk-middleware-auth/src/refresh-token-flow.js 84.61% <77.77%> (ø)
packages/csv-parser-price/src/main.js 92.47% <100.00%> (ø)
packages/discount-code-importer/src/main.js 100.00% <100.00%> (ø)
packages/inventories-exporter/src/main.js 95.60% <100.00%> (ø)
packages/personal-data-erasure/src/main.js 100.00% <100.00%> (ø)
packages/sdk-auth/src/auth.js 99.26% <100.00%> (ø)
packages/sdk-client/src/client.js 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dff86...2046b6c. Read the comment docs.

Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be quite a few formatting changes which make it harder to spot the real changes also as it's all in one commit. Can you perform a self review and comment on important areas changed? Thanks.

@ajimae
Copy link
Contributor Author

ajimae commented Feb 10, 2022

There seem to be quite a few formatting changes which make it harder to spot the real changes also as it's all in one commit. Can you perform a self review and comment on important areas changed? Thanks.

I will just go ahead and close this PR and open up another without all the extra file changes, I think that will be a lot easier.

@ajimae ajimae closed this Feb 10, 2022
@ajimae ajimae deleted the feat/add-retry-codes branch February 10, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants