chore(feedback): implement feedback

- use correct error class for error handling. - change network error to server error
commercetools · Jul 3, 2023 · f2907a1 · f2907a1
1 parent 5075964
commit f2907a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/sdk-middleware-http/src/http.js b/packages/sdk-middleware-http/src/http.js
@@ -10,7 +10,11 @@ import type {
   Next,
 } from 'types/sdk'
 
-import getErrorByCode, { NetworkError, HttpError } from './errors'
+import getErrorByCode, {
+  NetworkError,
+  HttpError,
+  InternalServerError,
+} from './errors'
 import parseHeaders from './parse-headers'
 
 function createError({ statusCode, message, ...rest }: Object): HttpErrorType {
@@ -310,7 +314,7 @@ export default function createHttpMiddleware({
                       return
                     }
 
-                  const error = new NetworkError(err.message, {
+                  const error = new InternalServerError(err.message, {
                     originalRequest: request,
                     retryCount,
                   })

diff --git a/packages/sdk-middleware-http/test/http.spec.js b/packages/sdk-middleware-http/test/http.spec.js
@@ -1023,8 +1023,8 @@ describe('Http', () => {
             'content-type': 'application/json',
           }
 
-          expect(res.error.code).toEqual(0)
-          expect(res.error.name).toEqual('NetworkError')
+          expect(res.error.code).toEqual(500)
+          expect(res.error.name).toEqual('InternalServerError')
 
           resolve()
         }