Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show hidden #268

Merged
merged 6 commits into from
Apr 4, 2018
Merged

Show hidden #268

merged 6 commits into from
Apr 4, 2018

Conversation

gbritton1
Copy link
Contributor

Currently, the UnParser returns a command line with hidden options exposed. I believe that this is wrong. This pull request changes that behavior:

  1. By default, the unparser will keep hidden options hidden
  2. I added a new UnParserSetting option, showHidden, to expose hidden options if you really want to

Of course, for any users expecting hidden options to be exposed by the unparser, this would be considered a breaking change. If that is unacceptable, it is a small thing to change the option to "hideHidden" to reverse the behavior.

enovales and others added 6 commits February 24, 2018 21:58
Short name not preferred? Go with long! No short name? Has to be long!
If there is no long name, take the short name regardless of the preference setting
Copy link
Member

@ericnewton76 ericnewton76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for the contribution

@ericnewton76 ericnewton76 changed the base branch from master to develop April 4, 2018 04:32
@ericnewton76 ericnewton76 changed the base branch from develop to master April 4, 2018 04:32
@ericnewton76 ericnewton76 changed the base branch from master to develop April 4, 2018 04:38
@ericnewton76 ericnewton76 merged commit 96a1ee3 into commandlineparser:develop Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants