Hyundai CAN-FD: Panda safety config assignments cleanup #29733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyhaibin
changed the title
This was referenced Sep 1, 2023
sshane
reviewed
Dec 15, 2023
Comment on lines
+309
to
+310
| if ret.flags & HyundaiFlags.CANFD_CAMERA_SCC or candidate in CAMERA_SCC_CAR: | ||
| ret.safetyConfigs[-1].safetyParam |= Panda.FLAG_HYUNDAI_CAMERA_SCC |
There was a problem hiding this comment.
We should only have one source of truth for this, why two? Combining the CAN and CAN FD logic here is slightly confusing, and there's no reason why it's different for both
We just make it common for CAN and CAN FD
sshane
added a commit
that referenced
this pull request
Feb 14, 2024
…)" This reverts commit 8009b11.
sshane
added a commit
that referenced
this pull request
Feb 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite of