HKG: Car Port for Hyundai Palisade and Kia Telluride 2023-24 (HDA2) #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
car
sunnyhaibin
force-pushed
the
palisade-2023-port-1-new
branch
from
648f3ae to
8f845ae
Compare
1 task
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
when this PR conna be accepted? |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
|
@adeebshihadeh @sshane can we please reopen this PR? |
Comment on lines
+36
to
+42
| elif CP.flags & HyundaiFlags.CAN_CANFD_HYBRID: | ||
| self.STEER_MAX = 384 | ||
| self.STEER_DRIVER_ALLOWANCE = 250 | ||
| self.STEER_THRESHOLD = 250 | ||
| self.STEER_DELTA_UP = 2 | ||
| self.STEER_DELTA_DOWN = 3 | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
selfdrive/car/docs.pyto generate new docs28aa956828c3407d|2023-01-28--21-56-53caf6a54b6d467dbd|2023-02-18--20-59-5828aa956828c3407d|2023-08-27--03-22-18caf6a54b6d467dbd|2023-02-28--21-18-30Hyundai NHyundai A (Modified) (HDA2), with CAN bus pairs flipped manually (see links below with instructions) ✅Link to all physical parts during installation
Supersedes
Requires