Refactor and cleanup Any? json deserialization
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it easier to read and comprehend a single assert that validates that the `meta` JSON dictionary parses as expected, vs. many asserts that cover each individual key/value.
This is re-usable generic code that `ErrorResponse` happens to rely on.
I didn't like how it split the map key/value types on newlines because annotations default to requiring newlines. Suppress the rule, and adjust the formatting to make the map key/value types easier to read.
Additionally, keep the main entry point helpers as `internal` but make additional support helpers `private`.
danielmorrison
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the generic
AnySerializer(that ourErrorResponseserializable data class relies on) into its own package and file.Adds some additional test coverage to ensure doubles and longs in JSON responses are converted properly. (Note that we don't test serialization as it's not relevant to our use case.)