Make relationchoice field works (Plone 5) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since context of the subform is a dictionary (which is correct)
|
I have an other approach in #71 for this. I think it is cleaner but needs some Plone fixtures too plone/Products.CMFPlone#2446 |
|
Closing this pull request as the altenative pull request in #71 was merged which also fixes the relation widgets. Please re-open if I misunderstood this. |
|
Reopening this myself as it hints to the problems in #31. At least part of this pull request makes sense to enable having vocabularies on field in the datagridfield, where the context is pulled from the parentForm and set on the subform. However, setting context on its widgets doesn't help, because the widget is reinstantiated in: If only we could get self.content on line 262 in fields.py to be the contet and not NO_VALUE ..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #31 #67 #50