Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when pattern class is not the first one, after adding a new row #199

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Fix bug when pattern class is not the first one, after adding a new row #199

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27028ab
Find and replace dgw-disabled-pat- regardless of where in the list of…
frapell Oct 29, 2024
0f47448
Update changes
frapell Oct 29, 2024
14bfb4d
Compile
frapell Oct 29, 2024
bf4f637
Update resources/js/datagridfield.pattern.js
petschki Nov 5, 2024
ae54d4d
udpate version pins
petschki Nov 5, 2024
5452090
yarn upgrade
petschki Nov 5, 2024
7b7534a
compile
petschki Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/198.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix bug when pattern class is not the first one, after adding a new row.
[frapell]
9 changes: 5 additions & 4 deletions resources/js/datagridfield.pattern.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,12 @@ export default Base.extend({

var $new_row = $(new_row);
// enable patternslib
$new_row
.find('*[class^="dgw-disabled-pat-"]')
.attr("class", function (i, cls) {
return cls.replace(/dgw\-disabled-pat-/, "pat-");
$new_row.find('[class*="dgw-disabled-pat-"]').each(function() {
const $element = $(this);
$element.attr('class', function(index, className) {
return className.replace(/\bdgw-disabled-pat-/g, 'pat-');
});
});
petschki marked this conversation as resolved.
Show resolved Hide resolved
return new_row;
},

Expand Down
1 change: 0 additions & 1 deletion src/collective/z3cform/datagridfield/static/chunks/245.26f6a815b7b177fc847b.min.js.map
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...ic/chunks/245.26f6a815b7b177fc847b.min.js → ...ic/chunks/245.658a6fa45b3927a4ecea.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/collective/z3cform/datagridfield/static/chunks/245.658a6fa45b3927a4ecea.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading