Add missing package name in setup.py. #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got lost in PR #173 when moving stuff over from setup.cfg to setup.py. I am surprised the tests passed. Effects this had: * Checking out the package with mr.developer did not work: the latest PyPI release was used. * So I tried creating an internal release to see if I could use that version. The source distribution ended up as a file named `collective-3.0.3.dev0+zest0.tar.gz`.
petschki
approved these changes
Jan 26, 2024
|
hm ... even more strange why the linting test are failing after merging 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got lost in PR #173 when moving stuff over from setup.cfg to setup.py. I am surprised the tests passed.
Effects this had:
collective-3.0.3.dev0+zest0.tar.gz.