Impl core::error::Error instead of std::error::Error #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
thanks for the great library! I noticed that the Error trait is not implemented for BuilderErrors when the
std
feature is inactive. Rust 1.81 stabilized core::error::Error, it would be nice if this crate could make use of it and lift the former restriction. Since, as implemented, this would be a breaking change, I'm wondering what the preferred way forward is. I can think ofcore_error
that opts into using core::error::Error instead of the std version#[rustversion::since(1.81)]