CATL-1564: Handle hidden (select) fields in submissions and emails

[nishant-bhorodia]

Overview

If the widget type for a civicrm select options is changed to hidden, then when viewing the submissions, it starts to show as IDs instead of labels.
For example, if the country field's widget type is changed to hidden then in submissions instead of showing the country name (In our case, United Kingdom), it will start to show ids (in our case, 1226).

D7 or D8?

This PR is for D7

Before

Submission

Email

After

Submission

Email

Technical Details

1. Handling of hidden fields, in terms of submission/email rendering, is like textfields. Meaning, whatever value they have, it is rendered as it is in submissions or emails send by webform.
2. But in our case we are making it possible to hide select fields which as a result, started showing ids instead of labels since the structure for select list and hidden fields is different.
3. To fix this, used function webform_civicrm_webform_submission_render_alter(&$renderable).
4. To check if the rendered field was select or not (before making it hidden), we are using wf_crm_field_options which returns options if the field has any (for select fields).
5. After detecting if the field was a select field, we are processing the field values and changing them to labels.

Comments

[nishant-bhorodia]

Hey @KarinG @colemanw ,
This passed testing on our end, please can you review?
thanks!!

[KarinG]

Hi @nishant-bhorodia - please see: my comment re: D8 here:
#337 (comment)