Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note case in which cache is not needed #233

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

vanschelven
Copy link

This wasn't noted anywhere. I'm perfectly happy with a more lengthy explanation but this PR at least adds something.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a4bc327) 99.28% compared to head (a27f367) 99.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files           7        7           
  Lines         280      280           
=======================================
  Hits          278      278           
  Misses          2        2           
Files Changed Coverage Δ
django_select2/forms.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vanschelven,

Thanks for the contribution. I love to see people improve the docs.

I left you a small suggestion.

Best!
Joe

docs/index.rst Outdated Show resolved Hide resolved
@codingjoe codingjoe merged commit 681fac9 into codingjoe:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants