-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow select2_js to be list #189
Conversation
In certain cases such as breakage to select2 like the one below, one can have a patch by loading another js. select2/select2#5993
Hi @pickfire, Thanks for reaching out. Interesting idea. Your implementation would change the API, but be backwards compatible. However, we might want to add deprecation here. I don't want to keep legacy code or type casting in the code forever. Deprecation, in the next major version, should be fine. I am curious though, what is your use case? What other JS do you need to inject his way? If it's unrelated, I'd recommend writing your own custom subclass to inject other form media. Cheers! |
Codecov ReportBase: 99.25% // Head: 99.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 99.25% 99.26%
=======================================
Files 7 7
Lines 270 272 +2
=======================================
+ Hits 268 270 +2
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
One js is to load the original select2 javascript, another js is to patch select2 bug to work with never version of jquery. See the issue I linked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I swapped the defaults to better reflect the ability to use lists in the documentation. Otherwise, I think we're good to go. Thanks @pickfire 👍
In certain cases such as breakage to select2 like the one below, one can have a patch by loading another js.
select2/select2#5993