-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #159 -- Add custom JSONEncoder support via setting #160
Conversation
Added support to set a custom JSON encoder via Django settings.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! This should do the trick. I left you a suggestion for your documentation. I'd like to keep a little shorter, while adding more backlinks to the Python docs. They actually have a pretty good example on how to extend encoders. We use inter-sphinx to create those links, if classes are marked accordingly in the docs.
Oh an @N1K1TAS95 you'll need to move the docstring under the attribute, to make it work. I'd recommend running |
Codecov ReportBase: 99.24% // Head: 99.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 99.24% 99.25%
=======================================
Files 7 7
Lines 264 267 +3
=======================================
+ Hits 262 265 +3
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Johannes Maron <[email protected]>
@codingjoe I've moved attribute docs under the attribute itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woop woop 🎉 let's ship it
Thanks! |
Added support to set a custom JSON encoder via Django settings.py