refactor: #72 use fast-excel instead of laravel excel

coding · Oct 22, 2021 · 8d970e9 · 8d970e9
1 parent 5b5375f
commit 8d970e9
Show file tree

Hide file tree

Showing 6 changed files with 309 additions and 1,307 deletions.
diff --git a/app/Commands/IssueImportCommand.php b/app/Commands/IssueImportCommand.php
@@ -4,9 +4,8 @@
 
 use App\Coding\Issue;
 use App\Coding\Project;
-use App\Imports\IssuesImport;
 use LaravelZero\Framework\Commands\Command;
-use Maatwebsite\Excel\Facades\Excel;
+use Rap2hpoutre\FastExcel\Facades\FastExcel;
 
 class IssueImportCommand extends Command
 {
@@ -51,7 +50,7 @@ public function handle(Issue $codingIssue, Project $codingProject): int
         foreach ($result as $item) {
             $issueTypes[$item['Name']] = $item;
         }
-        $rows = Excel::toArray(new IssuesImport(), $filePath)[0];
+        $rows = FastExcel::import($filePath);
         foreach ($rows as $row) {
             $data = [
                 'Type' => $issueTypes[$row['事项类型']]['IssueType'],

diff --git a/app/Imports/IssuesImport.php b/app/Imports/IssuesImport.php
diff --git a/composer.json b/composer.json
@@ -24,17 +24,15 @@
         "ext-zip": "*",
         "illuminate/database": "^8.40",
         "illuminate/log": "^8.0",
-        "illuminate/translation": "^8.64",
-        "illuminate/validation": "^8.64",
         "laravel-fans/confluence": "^0.1.1",
         "laravel-zero/framework": "^8.8",
         "league/html-to-markdown": "^5.0",
-        "maatwebsite/excel": "^3.1",
         "nesbot/carbon": "^2.53",
+        "rap2hpoutre/fast-excel": "^3.1",
         "sinkcup/laravel-filesystem-cos-updated": "^4.0"
     },
     "require-dev": {
-        "fakerphp/faker": "^1.9.1",
+        "fakerphp/faker": "^1.16",
         "mockery/mockery": "^1.4.3",
         "phpmd/phpmd": "^2.10",
         "phpunit/phpunit": "^9.5",