fix(inline-link): link insertion in safari #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested review from
gohabereg,
TatianaFomina and
ilyamore88
as code owners
e11sy
approved these changes
Nov 8, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Link insertion in Safari does not work
safari-link-bug.mov
Cause
Since #2758 we're checking all conteneditable elements for emptiness on each
inputevent.Dom.isEmpty()contains.normalize()call which changes the DOM structure. Theselection.restore()does not work then sincethis.savedSelectionRangeis not attached to actual Dom now.Solution
I have removed
.normalize()call from.isEmpty()check. It is unexpected side effect for such method.Resolves #2844
Resolves #2499
This PR is a patch for the latest stable version 2.30