Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(on-change): check data-mutation-free of parent nodes #2548

Merged
merged 15 commits into from
Jan 10, 2024
Merged

chore(on-change): check data-mutation-free of parent nodes #2548

merged 15 commits into from
Jan 10, 2024

Conversation

bettysteger
Copy link
Contributor

@bettysteger bettysteger commented Dec 5, 2023 •
edited by neSpecc
Loading

  • The data-mutation-free attribute now being checked for all parents of changed node
  • "characterData" mutations also now could be muted

Resolves #2205

I am rendering Vue components as Block Tools, for example a Video.js player. W I just play the video the editorjs gets a "block-changed" event and that's simply not true. The Video.js player creates lots of divs, where i have no "power" to set the data-mutation-free attribute!

@bettysteger bettysteger mentioned this pull request Dec 6, 2023
Closed
neSpecc
neSpecc reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line to the CHANGELOG.md please

neSpecc
neSpecc reviewed Dec 22, 2023
View reviewed changes
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@neSpecc neSpecc changed the title Add deep check data-mutation-free for mutation observer chore(on-change): check data-mutation-free of parent nodes Jan 10, 2024
@neSpecc neSpecc merged commit 4bdf7a1 into codex-team:next Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyamore88 ilyamore88 ilyamore88 approved these changes

@gohabereg gohabereg gohabereg approved these changes

@neSpecc neSpecc neSpecc approved these changes

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina TatianaFomina is a code owner

Assignees
No one assigned
Labels
important ready to be shipped
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 Optional mutation observer for block tools
4 participants
@bettysteger @neSpecc @gohabereg @ilyamore88