This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
replace low-level bitmap handling code with glide #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that is in place currently decodes a bitmap on the main thread, which can cause application responsiveness issues. The code also doesn't appear to scale down the bitmap in cases where the bitmap is much larger than the ImageView size. These two issues are described here: https://developer.android.com/topic/performance/graphics/index.html It looks like they recommend the use of Glide to handle these problems, so I've replaced the lower-level code with Glide code. This code may not be correct. I've never used glide (I typically use Picasso).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that is in place currently decodes a bitmap on the main thread,
which can cause application responsiveness issues. The code also doesn't
appear to scale down the bitmap in cases where the bitmap is much larger
than the ImageView size. These two issues are described here:
https://developer.android.com/topic/performance/graphics/index.html
It looks like they recommend the use of Glide to handle these problems, so I've replaced
the lower-level code with Glide code. This code may not be correct. I've never
used glide (I typically use Picasso).