-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github.com/gin-gonic/gin #318
Comments
P.S. There is PR which fix this issue: #310 |
Bump github.com/gin-gonic/gin from 1.6.3 to 1.7.0 fixes coder#318
I actuallly wonder how this is "single dependency" with all the other modules needed :) |
I'm also for the dependency removal, then struggle with its upgrades. The same is about |
All dependencies other than klauspost/compress are for tests alone. And dev has no dependencies whatsoever though I don't suggest running it in production yet. |
I'll remove gin soon and move the third party tests into a different module so they don't show up and cause all this confusion. |
Closing in favour of #297 |
Hi!
Could you please update the https://github.com/gin-gonic/gin. Github Dependabot send alerts to projects uses your nhooyr/websocket project because you use the https://github.com/gin-gonic/gin v1.6.3, but they need Patched version: 1.7.0.
See the message:
CVE-2020-28483
high severity
Vulnerable versions: < 1.7.0
Patched version: 1.7.0
This affects all versions of package https://github.com/gin-gonic/gin under 1.7.0. When gin is exposed directly to the internet, a client's IP can be spoofed by setting the X-Forwarded-For header.
I have use your https://github.com/nhooyr/websocket project in my https://github.com/kirill-scherba/teowebrtc project for make webrtc signaling client/server and this Github Dependabot alert is placed in my project page now :-)
I think you need just execute
go get -u
and publish new tag!Thanks.
Best regards,
Kirill Scherba.
The text was updated successfully, but these errors were encountered: