Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create branch 2.2. Yii2. #178

Closed
wants to merge 6 commits into from
Closed

Create branch 2.2. Yii2. #178

wants to merge 6 commits into from

Conversation

terabytesoftw
Copy link
Contributor

This PR is designed to create the 2.2 branch, which does not have deprecated methods, in addition, the github actions for phpunit, composer-require-checker and phpstan tests are implemented, it was typed, and the README.md badges were updated.

@terabytesoftw
Copy link
Contributor Author

terabytesoftw commented Oct 29, 2023

Here you can see the tests all in green. https://github.com/yii2-extensions/yii2-localeurls/actions

Regarding this Issue, it will not support Yii3 because the concept is totally different, but the update to Yii 2.2 is possible. #140

@mikehaertl
Copy link
Collaborator

Thanks for the contribution. I will need some time to go over the changes but from a first impression it looks good.

Sidenote: From the amount of work you invested here you seem to be very interested to keep this project alive (something I can not guarantee as I don't work on any new Yii projects anymore).

I could add you as a maintaner if you want. What do you think?

@terabytesoftw
Copy link
Contributor Author

If I have no problems, you can add me, i will be happy to help, so let's do the following, i'm going to close this PR, and i'm going to divide it into parts, to update the master with the legacy Yii2 version, then it will be simpler to create the branch 2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants