Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript errors #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxswjeon
Copy link

There are some typescript errors caused by untyped variables. Added types for local variables to resolve these errors.

Fix typescript errors caused by untyped variables
@marijnh
Copy link
Member

marijnh commented Oct 28, 2023

Which version of TypeScript produces the errors?

@maxswjeon
Copy link
Author

I'm using Typescript v5.2.2

@maxswjeon
Copy link
Author

The package built and exported does not have a typescript error. However, when I cloned the project to do some digging, I found out that it emits typescript error

@marijnh
Copy link
Member

marijnh commented Oct 29, 2023

I get no such errors when I build this code with 5.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants