WhatsAppPayload updated with the last click to chat feature and link … #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structure to send messages
codebude
requested changes
Oct 31, 2021
There was a problem hiding this comment.
I like to make QRCoder as user-friendly/easy to use as possible. The parameter comment, pointing out the exact number format is a good thing.
Nevertheless I would love to see some additional logic to remove illegal/wrong symbols in the number.
Do you mind adding in addition a Regex string replace that replaces all invalid chars from the number string? You could use the follow regex for example: https://regex101.com/r/wcshJu/1
(Replace everything the regex matches with an empty string.)
|
I'm closing this, since I merge your changes via an additional branch. See #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features:
What existing problem does the pull request solve?
1.- The WhatsApp Payload generates QR with link that have the old link structure to send automatically messages, in this pull request i updated the link generation structure and now it generate a QR correctly and when click open WhatsApp to send the message automatically