ui: fix db page Node/Regions column rendering

[xinhaoz]

Previously, the db page was not updating its columns if the
showNodeRegionsColumn prop changed. The db details page was
also not filtering out the regions column when desired.

Epic: none

Release note (bug fix): node/regions columns in db and db details
page should properly render. This column is hidden for tenants and
otherwise is shown for clusters with > 1 node.

[cockroach-teamcity]

This change is 

[THardy98]

left a small note/question

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

---

pkg/ui/workspaces/cluster-ui/src/databasesPage/databasesPage.tsx line 289 at r1 (raw file):

      prevProps.indexRecommendationsEnabled !==
        this.props.indexRecommendationsEnabled ||
      prevProps.showNodeRegionsColumn !== this.props.showNodeRegionsColumn

In principle, the change here is saying we should render this column if the # of nodes or regions changes to >1. Was this the case that was causing the cypress test to fail?

[THardy98]

oops meant to approve

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

[xinhaoz]

In principle, the change here is saying we should render this column if the # of nodes or regions changes to >1. Was this the case that was causing the cypress test to fail?

This bit was the part causing tests to fail, yes, but the prop was always based on if we had more than 1 node. The issue here was that we weren't recomputing the columns when this prop changed -- in the cypress testing it just so happens that this is the first page we request the nodes info, so the prop flips when the request returns.

[xinhaoz]

TFTR! Test failure unrelated to UI.
bors r+

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)