-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bundleReference to the claim specification #299
Merged
technosophos
merged 2 commits into
cnabio:master
from
technosophos:fix/297-bundle-reference
Dec 13, 2019
Merged
add bundleReference to the claim specification #299
technosophos
merged 2 commits into
cnabio:master
from
technosophos:fix/297-bundle-reference
Dec 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Butcher <[email protected]>
This was referenced Dec 11, 2019
adamreese
added a commit
to adamreese/libcnab-rust
that referenced
this pull request
Dec 11, 2019
adamreese
added a commit
to adamreese/libcnab-rust
that referenced
this pull request
Dec 11, 2019
cnabio#30 cnabio/cnab-spec#299 Signed-off-by: Adam Reese <[email protected]>
vdice
approved these changes
Dec 11, 2019
glyn
reviewed
Dec 12, 2019
radu-matei
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @glyn's suggestion.
Co-Authored-By: Glyn Normington <[email protected]>
glyn
approved these changes
Dec 12, 2019
adamreese
added a commit
to adamreese/libcnab-rust
that referenced
this pull request
Dec 18, 2019
cnabio#30 cnabio/cnab-spec#299 Signed-off-by: Adam Reese <[email protected]>
7 tasks
vdice
added a commit
to vdice/cnab-go
that referenced
this pull request
Mar 2, 2020
Ref cnabio/cnab-spec#299 Signed-off-by: Vaughn Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines an optional bundle reference as described in #297. I am not sure whether we should also have a relocation map stored inside of the claim, but if so this should be a separate PR.
Closes #297
Signed-off-by: Matt Butcher [email protected]