Update the docker driver to return early from fetchOutputs #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re no outputs defined on the operation. If there are none defined on the operation, there is a good chance /cnab/app/outputs won't exist and we shouldn't try to copy from it. If they do exist, we should continue and if it doesn't exist that is a failure case with that invocation image.
glyn
approved these changes
Aug 14, 2019
This was referenced Aug 15, 2019
carolynvs
pushed a commit
to carolynvs/cnab-go
that referenced
this pull request
Aug 16, 2019
* fix: fixed regressions * fix: fix all linter bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docker driver to return early from fetchOutputs when there are no outputs defined on the operation. If there are none defined on the operation, there is a good chance /cnab/app/outputs won't exist and we shouldn't try to copy from it in any case. This is currently an issue in duffle (and I assume any other tools that have updated the dependency to pick this up), when no outputs are defined in the bundle. This simply adds a boundary condition check.
If outputs are set on the operation, we should continue and if it doesn't exist that is a failure case with that invocation image.
I think there is a related change we should make where we only return the outputs defined on the operation. I think we are currently returning all the things in /cnab/app/outputs which is probably a little overly presumptive. I didn't handle that here, but I think it will be easier to handle now that the Operation is passed down into the method.
Closes #110.