Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Reading/Writing to Generic CIP Objects #50

Open
wants to merge 4 commits into
base: v2.0.0
Choose a base branch
from

Conversation

Penlane
Copy link

@Penlane Penlane commented Mar 20, 2019

This PR aims at using the inherent GET/SET_ATTRIBUTE(S)_SINGLE/ALL Service offered by CIP in order to allow accessing those objects by users

Description, Motivation, and Context

We can extract more information by being able to access the entirety of the CIP object library

How Has This Been Tested?

It is near-impossible to test the vast amount of available CIP Objects. I tested this on the TCP/IP Object and on the Identity Object of a RA-PLC.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. - mainly additive, if we want to inform the users about this feature
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants