Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for base EtherNet/IP Commands and Discovering Devices #49

Open
wants to merge 11 commits into
base: v2.0.0
Choose a base branch
from

Conversation

Penlane
Copy link

@Penlane Penlane commented Mar 20, 2019

Hi, this PR aims at utilizing the ENIP-side of the communication to provide nice QoL features like retrieving asset-data via EtherNet/IP or discovering several devices

Description, Motivation, and Context

The EtherNet/IP features of this library are well separated, which means we can also add more support here.

How Has This Been Tested?

The ListIdentity / ListServices commands have been tested several times on a live PLC.
Same with discovery. I'd like some feedback on how much information the discovery reply should contain. Only IP/Port/Slot? Or the whole listIdentity response?

Screenshots (if appropriate):

img

New Style of return:

img2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. (Maybe an addition that we can discover enip-capable devices)
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

@jhenson29
Copy link
Collaborator

I would vote for the entire reply.

Remove legacy discovery method and add more information to return of discovery.
Add attached interface to return value of Discovery method.
@Penlane
Copy link
Author

Penlane commented May 10, 2019

Alright, I extended the data that gets returned by the discovery-utility and adapted the format a little.
You can see the new reply in the second screenshot above.
We now know which interface the discovered devices are attached to.

@Penlane Penlane force-pushed the enipcommand-support branch from f965d77 to fb7dffa Compare May 17, 2019 08:22
@cmseaton42
Copy link
Owner

I am incorporating these changes into the typescript conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants