Add Base.isdone(itr::EachLine, state...)

With this method, `isempty` won't consume values from the iterator (See JuliaLang#27412).
cmcaine · Feb 7, 2021 · 5ef6ffa · 5ef6ffa
1 parent 59808cb
commit 5ef6ffa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/base/io.jl b/base/io.jl
@@ -1023,6 +1023,8 @@ eltype(::Type{<:EachLine}) = String
 
 IteratorSize(::Type{<:EachLine}) = SizeUnknown()
 
+isdone(itr::EachLine, state...) = eof(itr.stream)
+
 struct ReadEachIterator{T, IOT <: IO}
     stream::IOT
 end

diff --git a/test/read.jl b/test/read.jl
@@ -617,3 +617,12 @@ let p = Pipe()
     wait(t)
     close(p)
 end
+
+@testset "issue #27412" begin
+    itr = eachline(IOBuffer("a"))
+    @test !isempty(itr)
+    # check that the earlier isempty did not consume the iterator
+    @test !isempty(itr)
+    first(itr) # consume the iterator
+    @test  isempty(itr) # now it is empty
+end