Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add http2 docs #466

Merged
merged 5 commits into from
Dec 15, 2022
Merged

doc: add http2 docs #466

merged 5 commits into from
Dec 15, 2022

Conversation

Claude-Zq
Copy link
Contributor

What type of PR is this?

docs

What this PR does / why we need it (en: English/zh: Chinese):

en: Add documentation for HTTP2
zh: 添加了HTTP2的文档

Which issue(s) this PR fixes:

Fixes cloudwego/hertz#465

Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to #441 to refine pr.

@Claude-Zq
Copy link
Contributor Author

Please refer to #441 to refine pr.

Sorry,I referred to Websocket documentation earlier (also in the Protocol directory),and didn't notice that the http2 configuration was more complex and needed to be written into the documentation.
🤣

@Claude-Zq Claude-Zq requested review from a team as code owners December 14, 2022 12:16
Duslia
Duslia previously approved these changes Dec 14, 2022
@li-jin-gou
Copy link
Member

li-jin-gou commented Dec 14, 2022

PTAl @L2ncE @justlorain @BaiZe1998

@li-jin-gou li-jin-gou merged commit d8d1155 into cloudwego:main Dec 15, 2022
@li-jin-gou
Copy link
Member

LGTM

@Claude-Zq Claude-Zq deleted the add_HTTP2_doc branch December 16, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

docs: add documentation of HTTP2
5 participants