-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Socket.opened implementation #509
Conversation
Have you seen https://developers.cloudflare.com/workers/runtime-apis/tcp-sockets/#socket? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, we probably need to think about adding tests for this API.
Edit: To answer your question, I think we could do something clever with opened
in the Stream implementation, but I don't think its necessary for now.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [@grafbase/sdk](https://togithub.com/grafbase/grafbase) ([source](https://togithub.com/grafbase/grafbase/tree/HEAD/packages/grafbase-sdk)) | [`0.19.1` -> `0.19.2`](https://renovatebot.com/diffs/npm/@grafbase%2fsdk/0.19.1/0.19.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@grafbase%2fsdk/0.19.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@grafbase%2fsdk/0.19.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@grafbase%2fsdk/0.19.1/0.19.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@grafbase%2fsdk/0.19.1/0.19.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.12.3` -> `20.12.5`](https://renovatebot.com/diffs/npm/@types%2fnode/20.12.3/20.12.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fnode/20.12.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fnode/20.12.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fnode/20.12.3/20.12.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fnode/20.12.3/20.12.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@types/react-dom](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-dom) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom)) | [`18.2.23` -> `18.2.24`](https://renovatebot.com/diffs/npm/@types%2freact-dom/18.2.23/18.2.24) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact-dom/18.2.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact-dom/18.2.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact-dom/18.2.23/18.2.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact-dom/18.2.23/18.2.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [async-tungstenite](https://togithub.com/sdroege/async-tungstenite) | `0.25.0` -> `0.25.1` | [![age](https://developer.mend.io/api/mc/badges/age/crate/async-tungstenite/0.25.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/async-tungstenite/0.25.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/async-tungstenite/0.25.0/0.25.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/async-tungstenite/0.25.0/0.25.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [bun](https://bun.sh) ([source](https://togithub.com/oven-sh/bun)) | [`1.1.0` -> `1.1.2`](https://renovatebot.com/diffs/npm/bun/1.1.0/1.1.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/bun/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/bun/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/bun/1.1.0/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/bun/1.1.0/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [miette](https://togithub.com/zkat/miette) | `7.1.0` -> `7.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/crate/miette/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/miette/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/miette/7.2.0/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/miette/7.2.0/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dev-dependencies | patch | | [miette](https://togithub.com/zkat/miette) | `7.1.0` -> `7.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/crate/miette/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/miette/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/miette/7.2.0/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/miette/7.2.0/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [rustls-pemfile](https://togithub.com/rustls/pemfile) | `2.1.1` -> `2.1.2` | [![age](https://developer.mend.io/api/mc/badges/age/crate/rustls-pemfile/2.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/rustls-pemfile/2.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/rustls-pemfile/2.1.1/2.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/rustls-pemfile/2.1.1/2.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | workspace.dependencies | patch | | [swc_ecma_ast](https://togithub.com/swc-project/swc) | `0.112.6` -> `0.112.7` | [![age](https://developer.mend.io/api/mc/badges/age/crate/swc_ecma_ast/0.112.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/swc_ecma_ast/0.112.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/swc_ecma_ast/0.112.6/0.112.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/swc_ecma_ast/0.112.6/0.112.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [swc_ecma_parser](https://togithub.com/swc-project/swc) | `0.143.11` -> `0.143.12` | [![age](https://developer.mend.io/api/mc/badges/age/crate/swc_ecma_parser/0.143.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/swc_ecma_parser/0.143.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/swc_ecma_parser/0.143.11/0.143.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/swc_ecma_parser/0.143.11/0.143.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [tokio-postgres-rustls](https://togithub.com/jbg/tokio-postgres-rustls) | `0.11` -> `0.12` | [![age](https://developer.mend.io/api/mc/badges/age/crate/tokio-postgres-rustls/0.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/tokio-postgres-rustls/0.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/tokio-postgres-rustls/0.11.1/0.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/tokio-postgres-rustls/0.11.1/0.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | workspace.dependencies | minor | | [tokio-rustls](https://togithub.com/rustls/tokio-rustls) | `0.25` -> `0.26` | [![age](https://developer.mend.io/api/mc/badges/age/crate/tokio-rustls/0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/tokio-rustls/0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/tokio-rustls/0.25.0/0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/tokio-rustls/0.25.0/0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | workspace.dependencies | minor | | [type-fest](https://togithub.com/sindresorhus/type-fest) | [`4.14.0` -> `4.15.0`](https://renovatebot.com/diffs/npm/type-fest/4.14.0/4.15.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/type-fest/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/type-fest/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/type-fest/4.14.0/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/type-fest/4.14.0/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [typescript](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/TypeScript)) | [`5.4.3` -> `5.4.4`](https://renovatebot.com/diffs/npm/typescript/5.4.3/5.4.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/typescript/5.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/typescript/5.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/typescript/5.4.3/5.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/typescript/5.4.3/5.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [vite](https://vitejs.dev) ([source](https://togithub.com/vitejs/vite/tree/HEAD/packages/vite)) | [`5.2.7` -> `5.2.8`](https://renovatebot.com/diffs/npm/vite/5.2.7/5.2.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/vite/5.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite/5.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite/5.2.7/5.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite/5.2.7/5.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [worker](https://togithub.com/cloudflare/workers-rs) | `0.0.24` -> `0.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/crate/worker/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/worker/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/worker/0.0.24/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/worker/0.0.24/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [worker](https://togithub.com/cloudflare/workers-rs) | `0.0.24` -> `0.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/crate/worker/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/worker/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/worker/0.0.24/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/worker/0.0.24/0.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | workspace.dependencies | minor | --- ### Release Notes <details> <summary>grafbase/grafbase (@​grafbase/sdk)</summary> ### [`v0.19.2`](https://togithub.com/grafbase/grafbase/blob/HEAD/packages/grafbase-sdk/CHANGELOG.md#0192---Tue-Apr-2-2024) [Compare Source](https://togithub.com/grafbase/grafbase/compare/0.19.1...0.19.2) [CHANGELOG](changelog/0.19.2.md) </details> <details> <summary>sdroege/async-tungstenite (async-tungstenite)</summary> ### [`v0.25.1`](https://togithub.com/sdroege/async-tungstenite/blob/HEAD/CHANGELOG.md#0251---2024-04-03) [Compare Source](https://togithub.com/sdroege/async-tungstenite/compare/0.25.0...0.25.1) ##### Fixed - Fix tokio support for async-tls. </details> <details> <summary>oven-sh/bun (bun)</summary> ### [`v1.1.2`](https://togithub.com/oven-sh/bun/releases/tag/bun-v1.1.2): Bun v1.1.2 [Compare Source](https://togithub.com/oven-sh/bun/compare/bun-v1.1.1...bun-v1.1.2) To install Bun v1.1.2: ```bash curl https://bun.sh/install | bash ### or you can use npm ### npm install -g bun ``` Windows: ```bash powershell -c "irm bun.sh/install.ps1|iex" ``` To upgrade to Bun v1.1.2: ```bash bun upgrade ``` ##### **[Read Bun v1.1.2's release notes on Bun's blog](https://bun.sh/blog/bun-v1.1.2)** ##### Thanks to 7 contributors! - [@​dylan-conway](https://togithub.com/dylan-conway) - [@​Jarred-Sumner](https://togithub.com/Jarred-Sumner) - [@​mangs](https://togithub.com/mangs) - [@​nektro](https://togithub.com/nektro) - [@​paperdave](https://togithub.com/paperdave) - [@​sitiom](https://togithub.com/sitiom) - [@​zackradisic](https://togithub.com/zackradisic) **Full Changelog**: oven-sh/bun@bun-v1.1.1...bun-v1.1.2 ### [`v1.1.1`](https://togithub.com/oven-sh/bun/releases/tag/bun-v1.1.1): Bun v1.1.1 [Compare Source](https://togithub.com/oven-sh/bun/compare/bun-v1.1.0...bun-v1.1.1) To install Bun v1.1.1: ```bash curl https://bun.sh/install | bash ### or you can use npm ### npm install -g bun ``` Windows: ```bash powershell -c "irm bun.sh/install.ps1|iex" ``` To upgrade to Bun v1.1.1: ```bash bun upgrade ``` ##### **[Read Bun v1.1.1's release notes on Bun's blog](https://bun.sh/blog/bun-v1.1.1)** ##### Thank you to 8 contributors! - [@​cirospaciari](https;//github.com/cirospaciari) - [@​dylan-conway](https;//github.com/dylan-conway) - [@​gvilums](https;//github.com/gvilums) - [@​Jarred-Sumner](https;//github.com/Jarred-Sumner) - [@​mangs](https;//github.com/mangs) - [@​nektro](https;//github.com/nektro) - [@​paperdave](https;//github.com/paperdave) - [@​zackradisic](https;//github.com/zackradisic) **Full Changelog**: oven-sh/bun@bun-v1.1.0...bun-v1.1.1 </details> <details> <summary>jbg/tokio-postgres-rustls (tokio-postgres-rustls)</summary> ### [`v0.12.0`](https://togithub.com/jbg/tokio-postgres-rustls/releases/tag/v0.12.0) [Compare Source](https://togithub.com/jbg/tokio-postgres-rustls/compare/v0.11.1...v0.12.0) - Update rustls to 0.23 (thanks [@​aumetra](https://togithub.com/aumetra)!) </details> <details> <summary>sindresorhus/type-fest (type-fest)</summary> ### [`v4.15.0`](https://togithub.com/sindresorhus/type-fest/compare/v4.14.0...v4.15.0) [Compare Source](https://togithub.com/sindresorhus/type-fest/compare/v4.14.0...v4.15.0) </details> <details> <summary>Microsoft/TypeScript (typescript)</summary> ### [`v5.4.4`](https://togithub.com/microsoft/TypeScript/releases/tag/v5.4.4): TypeScript 5.4.4 [Compare Source](https://togithub.com/Microsoft/TypeScript/compare/v5.4.3...v5.4.4) For release notes, check out the [release announcement](https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/). For the complete list of fixed issues, check out the - [fixed issues query for Typescript 5.4.0 (Beta)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.0%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.1 (RC)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.1%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.2 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.2%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.3 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.3%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.4 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.4%22+is%3Aclosed+). Downloads are available on: - [NuGet package](https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild) </details> <details> <summary>vitejs/vite (vite)</summary> ### [`v5.2.8`](https://togithub.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small528-2024-04-03-small) [Compare Source](https://togithub.com/vitejs/vite/compare/v5.2.7...v5.2.8) - fix: csp nonce injection when no closing tag ([#​16281](https://togithub.com/vitejs/vite/issues/16281)) ([#​16282](https://togithub.com/vitejs/vite/issues/16282)) ([3c85c6b](https://togithub.com/vitejs/vite/commit/3c85c6b)), closes [#​16281](https://togithub.com/vitejs/vite/issues/16281) [#​16282](https://togithub.com/vitejs/vite/issues/16282) - fix: do not access document in `/@​vite/client` when not defined ([#​16318](https://togithub.com/vitejs/vite/issues/16318)) ([646319c](https://togithub.com/vitejs/vite/commit/646319c)), closes [#​16318](https://togithub.com/vitejs/vite/issues/16318) - fix: fix sourcemap when using object as `define` value ([#​15805](https://togithub.com/vitejs/vite/issues/15805)) ([445c4f2](https://togithub.com/vitejs/vite/commit/445c4f2)), closes [#​15805](https://togithub.com/vitejs/vite/issues/15805) - fix(css): unknown file error happened with lightningcss ([#​16306](https://togithub.com/vitejs/vite/issues/16306)) ([01af308](https://togithub.com/vitejs/vite/commit/01af308)), closes [#​16306](https://togithub.com/vitejs/vite/issues/16306) - fix(hmr): multiple updates happened when invalidate is called while multiple tabs open ([#​16307](https://togithub.com/vitejs/vite/issues/16307)) ([21cc10b](https://togithub.com/vitejs/vite/commit/21cc10b)), closes [#​16307](https://togithub.com/vitejs/vite/issues/16307) - fix(scanner): duplicate modules for same id if glob is used in html-like types ([#​16305](https://togithub.com/vitejs/vite/issues/16305)) ([eca68fa](https://togithub.com/vitejs/vite/commit/eca68fa)), closes [#​16305](https://togithub.com/vitejs/vite/issues/16305) - chore(deps): update all non-major dependencies ([#​16325](https://togithub.com/vitejs/vite/issues/16325)) ([a78e265](https://togithub.com/vitejs/vite/commit/a78e265)), closes [#​16325](https://togithub.com/vitejs/vite/issues/16325) - refactor: use types from sass instead of [@​types/sass](https://togithub.com/types/sass) ([#​16340](https://togithub.com/vitejs/vite/issues/16340)) ([4581e83](https://togithub.com/vitejs/vite/commit/4581e83)), closes [#​16340](https://togithub.com/vitejs/vite/issues/16340) </details> <details> <summary>cloudflare/workers-rs (worker)</summary> ### [`v0.1.0`](https://togithub.com/cloudflare/workers-rs/releases/tag/v0.1.0) [Compare Source](https://togithub.com/cloudflare/workers-rs/compare/v0.0.24...v0.1.0) ##### New Versioning Pattern We will be using `0.x.y` as our version pattern going forward so that we can better use semantic versioning. Minor version (`x`) changes will be used to indicate breaking changes, and patch version (`y`) changes will indicate non-breaking changes. We will continue be using `0` for our major version. ##### What's Changed ##### Sockets - Add `Socket.opened` for checking if socket connection was successful, by [@​Kakapio](https://togithub.com/Kakapio) in [https://github.com/cloudflare/workers-rs/pull/509](https://togithub.com/cloudflare/workers-rs/pull/509) - Add socket tests and fixed `Socket.closed` getter, by [@​kflansburg](https://togithub.com/kflansburg) in [https://github.com/cloudflare/workers-rs/pull/518](https://togithub.com/cloudflare/workers-rs/pull/518) ##### Binary Size - Make chrono-tz an optional dependency. This dependency was found to be a major contributor to binary size. By [@​kflansburg](https://togithub.com/kflansburg) in [https://github.com/cloudflare/workers-rs/pull/520](https://togithub.com/cloudflare/workers-rs/pull/520) > \[!CAUTION] > **Breaking:** You will now need the `timezone` feature to access `Cf.timezone`. - Introduce `axum` feature by [@​kflansburg](https://togithub.com/kflansburg) in [https://github.com/cloudflare/workers-rs/pull/534](https://togithub.com/cloudflare/workers-rs/pull/534) > \[!CAUTION] > **Breaking:** You will now need `axum` feature to have `From<worker::Response> for http::Response<axum::body::Body>` ##### D1 - Introduce methods on `D1PreparedStatement` to access `D1PreparedStatementSys` and raw `JsValue` query results, by [@​dakom](https://togithub.com/dakom) in [https://github.com/cloudflare/workers-rs/pull/521](https://togithub.com/cloudflare/workers-rs/pull/521) ##### HTTP - More flexible fetch handler signature allowing any type implementing `From<web_sys::Request>` for request argument by [@​dakom](https://togithub.com/dakom) in [https://github.com/cloudflare/workers-rs/pull/525](https://togithub.com/cloudflare/workers-rs/pull/525) ##### Other Fixes - Fix issue with data corruption in web_sys::WebSocket by [@​kflansburg](https://togithub.com/kflansburg) in [https://github.com/cloudflare/workers-rs/pull/523](https://togithub.com/cloudflare/workers-rs/pull/523) - Return 500 instead of panicking when returning error to fetch handler by [@​avsaase](https://togithub.com/avsaase) in [https://github.com/cloudflare/workers-rs/pull/524](https://togithub.com/cloudflare/workers-rs/pull/524) ##### Dependabot - chore(deps-dev): bump vite from 4.5.2 to 4.5.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/cloudflare/workers-rs/pull/532](https://togithub.com/cloudflare/workers-rs/pull/532) ##### New Contributors - [@​dakom](https://togithub.com/dakom) made their first contribution in [https://github.com/cloudflare/workers-rs/pull/521](https://togithub.com/cloudflare/workers-rs/pull/521) **Full Changelog**: cloudflare/workers-rs@v0.0.24...v0.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/grafbase/grafbase). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
#441
I'm a bit confused regarding the actual implementation of Socket.opened itself. I created all the necessary bindings, same as the ones already implemented, but I'm not sure if I'm done. The
Socket
struct confuses me. I know theinner
is the bound JS object itself, and the rest are mostly streams and options. What do Options such asclose
do? They are used in Tokio traits such asAsyncWrite
. It looks like to me that particular one returns whether the Socket has closed yet, and the implementation also indicates that. I tried to decipher what I think is the original implementation ofopened
but have not been successful in understanding it. I added anopened
Option to theSocket
struct but am not sure of what to do with it.Would it be incorrect to just implement it in
AsyncRead.poll_read()
?I think I just have to use reflection to grab the
opened
value onpoll_read()
?