Publish native Windows builds to npm #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penalosa
reviewed
Apr 3, 2023
mrbbot
force-pushed
the
bcoll/native-windows-npm
branch
from
3171309 to
e9cdee5
Compare
penalosa
approved these changes
Apr 3, 2023
|
@mrbbot looks like Upload binary step broken for windows? |
|
Hey! 👋 Where are you seeing the breakage? Windows builds won't be published until we do the next release (should be in the next couple days), so you won't see them right now. |
|
this step cannot find workerd.exe ? |
|
Ah ha! Great catch, thank you for reporting! 🙁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋 This PR updates the GitHub actions release workflows to build and publish native Windows builds to npm. A new
@cloudflare/workerd-windows-64package has been added, the required actions setup for Windows has been copied from #452, and Windows binary validation has been added back.