Ensure that crypto allocations are using BufferSource #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A handful of the remaining uses of |
jasnell
force-pushed
the
jsnell/crypto-allocations-using-buffersource
branch
from
107ae02 to
825d12d
Compare
anonrig
approved these changes
Nov 18, 2024
jasnell
force-pushed
the
jsnell/crypto-allocations-using-buffersource
branch
from
825d12d to
fd2ebad
Compare
erikcorry
approved these changes
Nov 19, 2024
| @@ -207,19 +207,28 @@ class CryptoKey: public jsg::Object { | |||
| KJ_SWITCH_ONEOF(publicExponent) { | |||
| KJ_CASE_ONEOF(array, BigInteger) { | |||
| if (fixPublicExp) { | |||
| auto expCopy = kj::heapArray<kj::byte>(array.asPtr()); | |||
| jsg::BackingStore expBack = jsg::BackingStore::from(kj::mv(expCopy)); | |||
| // alloc will, by default create a Uint8Array | |||
There was a problem hiding this comment.
If the comment is intended to document what type is hiding behind auto then would it not be nicer to just write the type there.
If that's not what is intended, then the reason for the comment is unclear.
... ensures that all ArrayBuffer instances are using sandboxed allocations rather than external allocations.
jasnell
force-pushed
the
jsnell/crypto-allocations-using-buffersource
branch
from
fd2ebad to
8ce6016
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... ensures that all ArrayBuffer instances are using BufferSource rather than external allocations.