Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node compatibility typescript infrastructure #258

Merged
merged 4 commits into from
Jan 11, 2023
Merged

node compatibility typescript infrastructure #258

merged 4 commits into from
Jan 11, 2023

Conversation

mikea
Copy link
Collaborator

@mikea mikea commented Jan 10, 2023

This change sets up the infrastructure necessary to implement node compatibility layer in typescript.

There are 3 smaller changes here:

  • setting up typescript project in src/node for node compat
  • defining modules.capnp structure for loading module bundles linked into the binary
  • generation module capnp for node source

@mikea mikea requested review from jasnell and kentonv January 10, 2023 22:37
jasnell
jasnell reviewed Jan 10, 2023
View reviewed changes
src/node/tsconfig.json Outdated Show resolved Hide resolved
@mikea
Copy link
Collaborator Author

mikea commented Jan 11, 2023

@jasnell all done, ptal

@mikea mikea merged commit dee37c5 into main Jan 11, 2023
@mikea mikea deleted the maizatskyi/2023-01-04-node_project branch January 11, 2023 18:36
mikea added a commit that referenced this pull request Jan 11, 2023
@mikea
Revert "node compatibility typescript infrastructure (#258)"
515d1b3 
This reverts commit dee37c5.
@mikea mikea mentioned this pull request Jan 11, 2023
Merged
mikea added a commit that referenced this pull request Jan 11, 2023
@mikea
Revert "node compatibility typescript infrastructure (#258)" (#262)
e064a8b 
This reverts commit dee37c5.
@mikea mikea mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@kentonv kentonv Awaiting requested review from kentonv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikea @jasnell