Add native support for Windows 🎉

As of cloudflare/workerd#452, `workerd` supports Windows' natively.
This change upgrades `workerd`, then removes the WSL and Docker
runtime shells.

.github/workflows/test.yml

@@ -18,7 +18,7 @@ jobs:
 
     strategy:
       matrix:
-        os: [ubuntu-latest] # `windows-latest` not yet supported
+        os: [ubuntu-latest, windows-latest]
         node: [16.13.0, latest]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 

packages/tre/package.json

@@ -39,7 +39,7 @@
     "source-map-support": "0.5.21",
     "stoppable": "^1.1.0",
     "undici": "^5.13.0",
-    "workerd": "^1.20230221.0",
+    "workerd": "^1.20230404.0",
     "ws": "^8.11.0",
     "youch": "^3.2.2",
     "zod": "^3.20.6"

packages/tre/src/index.ts

@@ -54,13 +54,11 @@ import {
 import {
   Config,
   Runtime,
-  RuntimeConstructor,
   RuntimeOptions,
   Service,
   Socket,
   Worker_Binding,
   Worker_Module,
-  getSupportedRuntime,
   serializeConfig,
 } from "./runtime";
 import {
@@ -214,12 +212,18 @@ const restrictedWebSocketUpgradeHeaders = [
 
 async function writeResponse(response: Response, res: http.ServerResponse) {
   const headers = Object.fromEntries(response.headers);
+  // process.stdout.write(`${response.status} ${response.statusText}\n`);
+  // for (const [key, value] of response.headers) {
+  //   process.stdout.write(`${key}: ${value}\n`);
+  // }
   res.writeHead(response.status, response.statusText, headers);
   if (response.body) {
     for await (const chunk of response.body) {
+      // if (chunk) process.stdout.write(chunk);
       if (chunk) res.write(chunk);
     }
   }
+  // process.stdout.write("\n");
   res.end();
 }
 
@@ -232,7 +236,6 @@ export class Miniflare {
   #log: Log;
   readonly #clock: Clock;
 
-  readonly #runtimeConstructor: RuntimeConstructor;
   #runtime?: Runtime;
   #removeRuntimeExitHook?: () => void;
   #runtimeEntryURL?: URL;
@@ -286,12 +289,6 @@ export class Miniflare {
     this.#clock = this.#sharedOpts.core.clock ?? defaultClock;
     this.#initPlugins();
 
-    // Get supported shell for executing runtime binary
-    // TODO: allow this to be configured if necessary
-    this.#runtimeConstructor = getSupportedRuntime();
-    const desc = this.#runtimeConstructor.description;
-    this.#log.debug(`Running workerd ${desc}...`);
-
     this.#liveReloadServer = new WebSocketServer({ noServer: true });
     this.#webSocketServer = new WebSocketServer({
       noServer: true,
@@ -386,12 +383,11 @@ export class Miniflare {
       inspectorPort: this.#sharedOpts.core.inspectorPort,
       verbose: this.#sharedOpts.core.verbose,
     };
-    this.#runtime = new this.#runtimeConstructor(opts);
+    this.#runtime = new Runtime(opts);
     this.#removeRuntimeExitHook = exitHook(() => void this.#runtime?.dispose());
 
     const accessibleHost =
-      this.#runtime.accessibleHostOverride ??
-      (host === "*" || host === "0.0.0.0" ? "127.0.0.1" : host);
+      host === "*" || host === "0.0.0.0" ? "127.0.0.1" : host;
     this.#runtimeEntryURL = new URL(`http://${accessibleHost}:${entryPort}`);
 
     const config = await this.#assembleConfig();

packages/tre/src/plugins/shared/gateway.ts

@@ -50,8 +50,9 @@ export const DEFAULT_PERSIST_ROOT = ".mf";
 export const PARAM_FILE_UNSANITISE = "unsanitise";
 
 export function maybeParseURL(url: Persistence): URL | undefined {
+  if (typeof url !== "string" || path.isAbsolute(url)) return;
   try {
-    if (typeof url === "string") return new URL(url);
+    return new URL(url);
   } catch {}
 }