Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable layout tests on iOS target #222

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Feb 6, 2024

Warnings of layout tests were already fixed in bindgen 0.60: rust-lang/rust-bindgen#1651.

@nox
Copy link
Collaborator

nox commented Mar 23, 2024

This needs a rebase.

@ldm0 ldm0 force-pushed the enable_bindgen_tests branch from 7212ef9 to 5685a61 Compare March 23, 2024 09:27
@ldm0
Copy link
Contributor Author

ldm0 commented Mar 23, 2024

Seems to be some unrelated clippy failure which can be fixed by #228. Currently blocked

@rushilmehra
Copy link
Collaborator

rushilmehra commented Mar 24, 2024

The clippy fixes are now merged

@ldm0 ldm0 force-pushed the enable_bindgen_tests branch from 5685a61 to 0045670 Compare March 24, 2024 17:54
@rushilmehra rushilmehra merged commit b96d2b8 into cloudflare:master Mar 24, 2024
23 checks passed
@rushilmehra
Copy link
Collaborator

Merged, thanks!

@ldm0 ldm0 deleted the enable_bindgen_tests branch March 24, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants