Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #653: add missing custom_ticket_statuses api call #654

Merged
merged 3 commits into from
Jan 26, 2024
Merged

fix for #653: add missing custom_ticket_statuses api call #654

merged 3 commits into from
Jan 26, 2024

Conversation

timveil
Copy link
Contributor

@timveil timveil commented Jan 9, 2024

this pr fixes #653 which adds support for the custom_ticket_statuses api call found here...https://developer.zendesk.com/api-reference/ticketing/tickets/custom_ticket_statuses/

PierreBtz
PierreBtz reviewed Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Same remarks as the previous PR:

  • spotless need to be run using java 8
  • would you mind adding a test?

Thanks!

src/main/java/org/zendesk/client/v2/Zendesk.java Outdated Show resolved Hide resolved
@PierreBtz
Copy link
Collaborator

Sorry, missed the draft status...

@timveil timveil marked this pull request as ready for review January 19, 2024 21:16
@timveil timveil requested a review from duemir as a code owner January 19, 2024 21:16
@timveil
Copy link
Contributor Author

timveil commented Jan 23, 2024

I think this is ready if you are

PierreBtz
PierreBtz approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, it seems our test instance doesn't have custom status instance enabled so I cannot have a test running on this feature.

@PierreBtz PierreBtz merged commit 38715db into cloudbees-oss:master Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreBtz PierreBtz PierreBtz approved these changes

@duemir duemir Awaiting requested review from duemir duemir is a code owner

Assignees
No one assigned
Labels
DO NOT MERGE enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for custom_ticket_statuses
2 participants
@timveil @PierreBtz