fixes #651: adds custom_status_id to Request object
#652
Conversation
…NG.doc. this allows my to pass the `Spotless Maven Plugin` checks locally
|
Any thoughts on this @duemir or @PierreBtz |
There was a problem hiding this comment.
The change itself look good.
When making this change, I encountered many files which did not adhere to the Spotless Maven Plugin format.
I very much doubt that (since it would fail the build), rather that you used a jdk11/17/21 take your pick instead of java 8.
I noticed in the past that the formatter had a different output with Java 8 for some reason.
The library is still using java 8.
Would it be possible for you to add a test?
Thanks for the contribution :)
The update integrates tests for custom ticket status ID into the Ticket and TicketResult test classes. This ensures that the custom ID property is recognized correctly and can be parsed from JSON appropriately.
|
i re-ran As for tests, since this change is simply adding a property I don't think it requires a full blown test, but happy to copy an example test if you have one you can point me too. In the meantime i did add the property to both |
this PR fixes #651. It adds the missing
custom_status_idfield to the Response object so that is available on Ticket. When making this change, I encountered many files which did not adhere to theSpotless Maven Pluginformat. This PR also applies thegoogle-java-formatto all files thus resolving the spotless issues.